Pipeline fails because format-check.sh check Haskell files from lecture
The pipeline fails when push because lecture Haskell files violate formatting and linting advice.
for example,
- Hlint gives out warning for re-implementing
listMap
inS04_Function.hs
- Not using camel case for variable naming in
S03_Expression.hs
- Whitespace formatting
Some of the issues can be fixed with formatting, but some cannot (like not re-implementing listMap
in 1), and there will likely to be more in the future.
I think the format-check should ignore lecture files which name start with S..
, so it will be convenient for both Professor for lecturing and people who push their work to their own private fork (to not get "build failed" email.)
I have made a merge request !4, that change format-check.sh
to ignore the files from lecture. Please take a look at it.
Sorry that I did not have time to make a proper explanation about my MR earlier.